scorelab / imagelab

ImageLab is a standalone tool which supports anyone to get started with image processing related concepts and techniques in an interactive, less logical way.

Apache License 2.0

46 stars 60 forks source link

added initialization from remote origin in Electron app to resolve the error #174

Closed nsginx closed 10 months ago

nsginx commented 10 months ago

Description

Added a remoteMain in main.js and initialized it. So the issue which was arising while running the electron app is now resolved.

Fixes #173

no issue is visible now.

the previous error is removed

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

it was a project initialisation error.

Also, include screenshots for verification and reviewing purpose.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented on my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

abdullahranginwala commented 10 months ago

@nazmus-saqib008 Why does this PR have 44 commits? Can you please rectify the merge conflicts?

nsginx commented 10 months ago

@abdullahranginwala i'm also surprised. is it because of pr to development branch? should i change it to master ?