search

scorelab / kute

Commute app for Sri Lanka
Apache License 2.0
32 stars 77 forks source link

ImageRequest function is Volley library is deprecated! #28

Open CloudyPadmal opened 7 years ago

CloudyPadmal commented 7 years ago

Issue

The image request call made to fetch images from URL is deprecated. Picasso is a library specialized in image fetching compared to Volley. We can integrate that library instead of Volley as volley hasn't been use anywhere in the app except for image fetching

Steps to reproduce

  1. Go to RegisterActivity class
  2. Find "ImageRequest"

Would you like to work on this issue?

Yes and I can send a PR for review!

icancode23 commented 7 years ago

@CloudyPadmal brother you can use image loader as well...using the same volley library..

CloudyPadmal commented 7 years ago

@icancode23 agreed! But picasso is simple to integrate than volley! Don't you agree? :)

icancode23 commented 7 years ago

@CloudyPadmal no i was just saying that because then you won't need an additional dependency of picasso

CloudyPadmal commented 7 years ago

@icancode23 volley is only used in this image fetching. So instead of that we can use Picasso, a library specialized in image fetching from URLs to simplify the code!!

icancode23 commented 7 years ago

@CloudyPadmal two developers..two different thinking....

CloudyPadmal commented 7 years ago

That's good for app development! :)