search

scorninpc / php-gtk3

GTK3 extension for PHP
https://andor.com.br/
GNU Lesser General Public License v3.0
118 stars 13 forks source link

implement label set_line_wrap_mode #114 #120

Closed d47081 closed 4 months ago

d47081 commented 4 months ago

Solution for #114

https://docs.gtk.org/gtk3/method.Label.set_line_wrap_mode.html https://docs.gtk.org/Pango/enum.WrapMode.html (dependency)

scorninpc commented 4 months ago

Can you compile that without modify Makefile?

https://github.com/scorninpc/php-gtk3/blob/master/Makefile#L139

d47081 commented 4 months ago

I didn't changed 139 line in my makefile, only these lines as following:

INI_DIR        =  /etc/php/8.2/mods-available/
EXTENSION_DIR  =  $(shell /opt/php/php-8.3.9/bin/php-config --extension-dir)

it is not work for you?

p.s. Could you advice with this dependency point: https://github.com/scorninpc/php-gtk3/pull/120/commits/38087c68c746e6b71b15763beab46b6861551352#diff-69c514758c693ab28fb406d30ac968b9cd15de3335dface44d61a5b5608817e6R6

d47081 commented 4 months ago

Can you compile that without modify Makefile?

@scorninpc seems now I understand your question, this PR branch compiling without any alerts and changes in Makefile SOURCES

Just forgot about, strange there was no alerts on build.

finally I have added Pango namespaces by PR #122 (137 and 139 lines)

d47081 commented 4 months ago

can we merge current 4 PRs because I'm stuck with dependencies and worried about master conflicts resolving.

I've tested everything there. Without 110 it's hard to debug, so important for me also