search

scorninpc / php-gtk3

GTK3 extension for PHP
https://andor.com.br/
GNU Lesser General Public License v3.0
118 stars 13 forks source link

Pending for PR dependencies #126

Closed d47081 closed 4 months ago

d47081 commented 4 months ago

@scorninpc could you please merge those 4 pull reuests because I want to implement new features about drawing area and worried about future conflicts because I'm using current master branch as the source for each new feature.

I have tested them all

scorninpc commented 4 months ago

Yes i can, but i need a working code to test if pr works and if dont break another things

d47081 commented 4 months ago

Working code attached to PRs, well I maybe give up to wait / contribute here.

scorninpc commented 4 months ago

look d47081, I really appreciate your willingness to use, test and contribute to the project

but you need to understand that this is not my main job, I have other projects, another company to take care of, and many other things

your issues and PRs are confusing, there's rarely any logs, code or anything that I can just run it and see the same error you're seeing, and every time I need to imagine your code, code it, just to test if something wrong occurs, and try to imagine if that is the problem, it takes a lot of time

your attached code is not a working code, it's just a object creation and a dump. I cannot run this and see what this is for

my choice in using PHP-CPP was precisely to be able to open a project that even someone with little knowledge of C could help with, but for that I need people to also help me maintain it

I hope you understand that maintaining a project is complicated and delicate, especially because you also have some great projects, and that you don't give up on contributing

d47081 commented 4 months ago

Thanks for merge,

sure, I understand you are busy, just second week I'm waiting and thinking what to do, because

  1. I can make changes directly to my branch and don't care
  2. or, bit harder, but share updates with official master branch also (because I really like this project)

but when follow 2'th variant, after 1-2 PRs I don't remember which of dependencies was implemented and worried about conflicts with previous ones as master become deprecated with every new feature implementation. Not always but sometimes. I'm creating new branch from deprecated master for every new feature, that makes me mad :)

Okay, I'll try to attach code examples. One problem, my testing app have object layer and I must to write example code from zero not always have a time / intention for that :)

e.g. I have one more feature but it's not work for me as expected, so did not sent as PR yet

scorninpc commented 4 months ago

e.g. I have one more feature but it's not work for me as expected, so did not sent as PR yet

In generaly, this is the problem. I never used gtk_label_select_region so i dont know how/where/when use it. with some code, some example, prints, videos, anything, can help alot

d47081 commented 4 months ago

I'm trying to keep GtkLabel text selection between GtkNotebook tab switch, but it's not work for me - maybe I forgot about some related label setter.. just first experience with GTK at all. Sometimes trying rare methods and found they are not implemented in PHP-GTK3