phpversion return 1.0 for php-gtk3

[d47081]

Is bug or not?

<?php 

var_dump(
    phpversion('php-gtk3')  // return 1.0
);

I'm using latest version from repo, where last stable release has 0.16 Beta version: https://github.com/scorninpc/php-gtk3/releases

[scorninpc]

i never saw this, i'll look it up

[d47081]

I'm just using versions for issues report in my app and not sure php-gtk return correct one that in use (repo in my case)

[scorninpc]

This is correct. As this a very beta version, I didn't change versions yet

https://github.com/scorninpc/php-gtk3/blob/master/main.cpp#L31

I'll start release with the same version, next release ok?

[d47081]

No problem, just reporting that feature in use ;)

[d47081]

one tip about lib versions model, for better understanding when updates contain compatible api changes by version number https://semver.org

[d47081]

I saw also an implementation, where repository version has commit postfix

for example on this splash window (we can grab implementation from there as cpp)

https://github.com/kvazar-network/kevacoin/releases/tag/kvazar-1.1.0

[scorninpc]

I saw also an implementation, where repository version has commit postfix

hahaha no thanks

[scorninpc]

ah ok, I thought you wanted to make a screen like this ready-made

[d47081]

lol, nope of course :) just hash at version postfix to know which repo snap in use when user report a bug.

plus this way does not require versions change all the time, because usually master branch contain version of the future release, but nothing about the real project state (so hash would be useful for testing builds)

currently my app uses master branch because of latest features dependency, but later I plan to switch the stable tags (in releases)

just an idea for apps with rolling updates.