search

scorninpc / php-gtk3

GTK3 extension for PHP
https://andor.com.br/
GNU Lesser General Public License v3.0
118 stars 13 forks source link

GtkWindow constructor #157

Closed d47081 closed 3 months ago

d47081 commented 3 months ago

https://docs.gtk.org/gtk3/ctor.Window.new.html

By the documentation, constructor must contain https://docs.gtk.org/gtk3/enum.WindowType.html

PHP access implemented in https://github.com/scorninpc/php-gtk3/pull/156

If API has another implementation, it would be more correct to set on cpp side GTK_WINDOW_TOPLEVEL not 0

d47081 commented 3 months ago

fixed hard coded zero by https://github.com/scorninpc/php-gtk3/pull/156/commits/6d746de327d74da7e123e13a5fe481e21990880d

maybe that's no sense to change lib api for compatibility reasons, so closing.

scorninpc commented 3 months ago

maybe that's no sense to change lib api for compatibility reasons

for real? hahahah

gtkwindow was one of the first methods that was programmed. This change would be great. It's a shame that you think so.

d47081 commented 3 months ago

This change would be great. It's a shame that you think so.

I think so because lot of people probably using master branch (with own php configuration), and window is the initial widget that require API upgrade for maybe 100% of apps.

Plus another methods have array on return not linked arguments as documented to care about here.