search

scorpionmit01 / homebridge-jewish-calendar

Homebridge Plugin that provides contact sensors related to the Jewish Calendar.
MIT License
3 stars 3 forks source link

Offset Time #3

Closed moshed closed 3 years ago

moshed commented 3 years ago

hey its me from the other thread. its kind of difficult to test these out as during kodesh times as you cant use the phone. would it be possible to set an offset time so that we can test this out easily

scorpionmit01 commented 3 years ago

So I run mine on a Raspberry Pi for Homebridge. I turn off the Time Sync, and shift the time on the Homebridge.

But that's a great idea. If nobody gets a chance to look at it in the next few days I'll implement it.

Thanks, Alex

On Wed, Jan 20, 2021 at 9:42 PM moshed notifications@github.com wrote:

hey its me from the other thread. its kind of difficult to test these out as during kodesh times as you cant use the phone. would it be possible to set an offset time so that we can test this out easily

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/scorpionmit01/homebridge-jewish-calendar/issues/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYN4VI22S36ZL3WGUPVHBTS26IALANCNFSM4WL7KHSQ .

-- Book a meeting with me https://www.cloudhq.net/meeting/alexhochberger@gmail.com

scorpionmit01 commented 3 years ago

Thoughts on implementation, add a field offset, and the time should shift forward/backward by that many minutes?

moshed commented 3 years ago

yeah! that exactly how I had it in mind.

https://github.com/grover/homebridge-calendar has an offset that is customizable with suffixes for days but the math is easily done for dy to minute conversion so maybe that's overkill.

scorpionmit01 commented 3 years ago

Implemented in v1.1.0, released tonight.

scorpionmit01 commented 3 years ago

I put it out there. Happy hacking!

On Wed, Jan 20, 2021 at 10:57 PM moshed notifications@github.com wrote:

yeah! that exactly how I had it in mind.

https://github.com/grover/homebridge-calendar has an offset that is customizable with suffixes for days but the math is easily done for dy to minute conversion so maybe that's overkill.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/scorpionmit01/homebridge-jewish-calendar/issues/3#issuecomment-764219793, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYN4VKBXAK4NHEVB27BH53S26QZ3ANCNFSM4WL7KHSQ .

-- Book a meeting with me https://www.cloudhq.net/meeting/alexhochberger@gmail.com

moshed commented 3 years ago

Wow. Quick turnaround!