search

scorpionmit01 / homebridge-jewish-calendar

Homebridge Plugin that provides contact sensors related to the Jewish Calendar.
MIT License
3 stars 3 forks source link

Kodesh turning on too early #8

Open DanielSmith1239 opened 2 years ago

DanielSmith1239 commented 2 years ago

Hello, My Kodesh switch seems to be turning on around an hour and a half too early on shabbos. I double checked my lat/lng.

also another minor thing, the setting for “longitude” seems to say “latitude” instead.

scorpionmit01 commented 2 years ago

I will take a look. Thank you for the feedback. Shabbat Shalom and Chag Sameach.

Sent from my iPhone

On Jun 3, 2022, at 7:22 PM, Dani Smith @.***> wrote:

 Hello, My Kodesh switch seems to be turning on around an hour and a half too early on shabbos. I double checked my lat/lng.

also another minor thing, the setting for “longitude” seems to say “latitude” instead.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

DanielSmith1239 commented 2 years ago

Hello, can you add support for iOS 16 as well? All of the contact sensors have the same name in iOS 16

scorpionmit01 commented 2 years ago

Thanks for the heads up. I'm not an iOS developer. Can you send screen shots of what you are seeing in iOS 16 and I'll see what I can do?

Looks like I need a v2 this summer.

On Tue, Jun 7, 2022 at 11:26 AM Dani Smith @.***> wrote:

Hello, can you add support for iOS 16 as well? All of the contact sensors have the same name in iOS 16

— Reply to this email directly, view it on GitHub https://github.com/scorpionmit01/homebridge-jewish-calendar/issues/8#issuecomment-1148824497, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYN4VI7LYPG4P5QOFSCYCTVN5S3BANCNFSM5X2N2JPA . You are receiving this because you commented.Message ID: @.***>

-- Book a meeting with me @.***>

DanielSmith1239 commented 2 years ago

6A5B5488-E34E-433C-96F1-8980F2837C41 45192669-3BBF-43AF-92D0-51DC807892A2

DanielSmith1239 commented 2 years ago

Hello, have you been able to take a look at this at all? An alternative to using the npm packages (if those are causing the issues) would be to use the hebcal Jewish Calendar API (https://www.hebcal.com/home/195/jewish-calendar-rest-api), cache the calendar somewhere, and simply use that to activate the switches.

scorpionmit01 commented 2 years ago

The Hebcal API was much more of a lift to implement than I wanted to do when I first started it out.

I will try to take a look at addressing it, I apologize I have been away for the past few months.

Sent from my iPhone

On Sep 5, 2022, at 11:27 AM, Dani Smith @.***> wrote:

 Hello, have you been able to take a look at this at all? An alternative to using the npm packages (if those are causing the issues) would be to use the hebcal Jewish Calendar API (https://www.hebcal.com/home/195/jewish-calendar-rest-api), cache the calendar somewhere, and simply use that to activate the switches.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.