search

scorpiusjs / scorpius

Modular admin solution built with Meteor
http://scorpiusjs.org
MIT License
34 stars 7 forks source link

fix for materialize button session variable #47

Closed JulianKingman closed 7 years ago

JulianKingman commented 7 years ago

Fixes and implements this fix: https://github.com/sean-stanley/orion/commit/256e91bc39b96ec75cbbdf976d2deb0c2060cefc

It wasn't implemented correctly (should have used ReactiveTemplates.onRendered), and wasn't included in package.js

Thanks!

rwatts3 commented 7 years ago

Good deal. I will test and get this merged. Thank you.

On Thu, Mar 9, 2017, 2:07 PM JulianKingman notifications@github.com wrote:

Fixes and implements this fix: sean-stanley/orion@256e91b https://github.com/sean-stanley/orion/commit/256e91bc39b96ec75cbbdf976d2deb0c2060cefc

It wasn't implemented correctly (should have used ReactiveTemplates.onRendered), and wasn't included in package.js

Thanks!

You can view, comment on, or merge this pull request online at:

https://github.com/scorpiusjs/scorpius/pull/47 Commit Summary

  • fix for materialize button session variable

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/scorpiusjs/scorpius/pull/47, or mute the thread https://github.com/notifications/unsubscribe-auth/AFFsSQEIE4080zgIztGsoQF60P_n0fr1ks5rkGoSgaJpZM4MYolb .

rwatts3 commented 7 years ago

nice work !

JulianKingman commented 7 years ago

Thanks :)

JulianKingman commented 7 years ago

The buttons.js file didn't get included into the package.js file

JulianKingman commented 7 years ago

@rwatts3 the buttons.js file didn't get included into the package.js file

rwatts3 commented 7 years ago

Oh wow sure didn't.

rwatts3 commented 7 years ago

Ok a new package version is published with buttons.js 0.3.1_4

JulianKingman commented 7 years ago

Awesome, works great!