coveralls
commented
6 years ago Pull Request Test Coverage Report for Build 313
- 84 of 97 (86.6%) changed or added relevant lines in 21 files are covered.
- 2 unchanged lines in 2 files lost coverage.
- Overall coverage increased (+0.4%) to 80.369%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/app/action/buttons/buttons.component.ts | 2 | 3 | 66.67% | ||
| src/app/model/game.ts | 10 | 11 | 90.91% | ||
| src/app/prestige/prestige.component.ts | 0 | 1 | 0.0% | ||
| src/app/research/research.component.ts | 2 | 3 | 66.67% | ||
| src/app/model/world.ts | 17 | 20 | 85.0% | ||
| src/app/model/masteries/all-masteries.ts | 13 | 19 | 68.42% | ||
| <!-- | Total: | 84 | 97 | 86.6% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/app/production-signposts/production-signposts.component.ts | 1 | 79.31% | ||
| src/app/model/game.ts | 1 | 72.81% | ||
| <!-- | Total: | 2 | --> |
| Totals | |
|---|---|
| Change from base Build 311: | 0.4% |
| Covered Lines: | 3389 |
| Relevant Lines: | 3932 |
scorzy
This should hopefully address most of Issue #13 and clean up some small variable name typos too. The biggest one I intentionally didn't mess with changing
CONSTATS.tstoCONSTANTS.ts. If you want me to squash all these commits together, let me know.I did run it locally and verify that works, as well as run
npm run testwhich seems to pass as well as before. Some of the other tests were failing beforehand and as far as I can aren't being used. Let me know if there's more changes you'd like to see!