scosman / zipstreamer

Zip File Streaming Microservice - stream zip files on the fly
MIT License
120 stars 18 forks source link

Log warnings for unretrievable URLs in descriptor #29

Open danlamanna opened 1 year ago

danlamanna commented 1 year ago

These lines silently ignore URLs that can't be retrieved: https://github.com/scosman/zipstreamer/blob/ebcdb4258485f768077a5c7214944cd2e01dfa07/zip_streamer/zip_streamer.go#L37-L44

scosman commented 1 year ago

P2: if anyone want to tackle this would take to master, but not a top issue. Would need to be behind a config flag ZS_LOG_UPSTREAM_ERRORS which still would default off.

Why I don't think this is on by default: