Resolved: "// TODO: flush after every 32kb instead of every file to r…

scosman / zipstreamer

Zip File Streaming Microservice - stream zip files on the fly

MIT License

119 stars 18 forks source link

Closed jtrinh27 closed 1 year ago

jtrinh27 commented 2 years ago

flush after every 32kb instead of every file to reduce memory

skrivy commented 2 years ago

@scosman Could you please get this merged? Thank you

skrivy commented 2 years ago

Ok. I can see that related project has been taken down and this pull request is still open.

scosman commented 1 year ago

Thanks for the patch!

io.Copy apparently already does use a 32KB buffer (strange it's the exact amount from my comment, but I'll take it).

Closing since this is not needed. I'll clean up the comment.