search

scotch / angular-brunch-seed

AngularJS + Brunch
Other
228 stars 78 forks source link

submit contribution and config clean #12

Closed ilkosta closed 12 years ago

ilkosta commented 12 years ago

I added the coffeelint-brunch plugin and cleaned the wrapper function from the config.

I've submitted an issue to Brunch for the possibility to manage the wrapper function according to the compiled file extension.

ilkosta commented 12 years ago

Why not delete the wrapper function from the config? I think that at the moment this isn't necessary and can create confusion to the users that don't want to use only angularjs/jade.

kylefinley commented 12 years ago

Maybe we could remove the wrapper -- the reason that I reverted your change was that it caused brunch to wrap the modules in commonjs functions, default, which broke things.

Is this the behavior that you were wanting?

  modules:
    definition: false
    wrapper: false

I do like the idea of removing the wrapper. I'll make the change.

kylefinley commented 12 years ago

As of 8a5f08916ced8b4fb93e3e66dfaa02dfdc399656 the wrapper has been removed. Thank you for the suggestion.