search

scotch / angular-brunch-seed

AngularJS + Brunch
Other
228 stars 78 forks source link

jade compiler script #20

Closed fimble closed 11 years ago

fimble commented 11 years ago 
node_modules/.bin/jade app/index.jade --pretty --out app/assets/
node_modules/.bin/jade app/partials/ --pretty --out app/assets/partials/

rm app/index.jade && rm -rf app/partials/

this is really what you mean:

rm app/index.jade && rm -rf app/partials/

?! maybe:

rm app/assets/index.html && rm -rf app/assets/partials/
node_modules/.bin/jade app/index.jade --pretty --out app/assets/
node_modules/.bin/jade app/partials/ --pretty --out app/assets/partials/
fimble commented 11 years ago

And, funny, I can't clone this repo :) because, github redirect me to my angular-brunch-seed-livescript !

kylefinley commented 11 years ago

Hi @fimble,

With this commit f050cc075e2038a6ded3df05d563a32f22203cb1 jade templates were moved to /app/partials. It appears that angular-brunch-seed-livescript hasn't merged these changes -- that's why the *.jade files are still in the /app/assets/partials directory for you.

Does that resolve this issue?

-Kyle

fimble commented 11 years ago

but why 'rm -rf /app/partials'? If /app/partials - jade sources, then this command will remove my sources, eh?

kylefinley commented 11 years ago

Yes that script is intended for HTML users that have no intension of using Jade. I thought that it made sense to delete the files since they won't be using them. Maybe this could be more clear in the docs, what do you think the best way to word this would be?

And just to be clear if you're using Jade you no longer need to run a script in the background. As of the commit f050cc075e2038a6ded3df05d563a32f22203cb1 the jade files now compile automatically on save.

fimble commented 11 years ago

Ok, now I understand what happens. But, sadly, static-jade-brunch didn't work here :( And, in angular-seed-livescript too.

fimble commented 11 years ago

try to delete app/assets/partials, and brunch build don't create this folder.

fimble commented 11 years ago

index.html not created too. only js/templates.js

kylefinley commented 11 years ago

You are absolutely correct. It appears that a bug was introduced in static-jade-brunch v1.4.7. I have reverted to 1.4.5 and everything seems to be working now. Could you please test it?

I'll investigate further to see what the cause of this may be. Thank you for reporting this.

kylefinley commented 11 years ago

staic-jade-brunch is working again. 582ffc993cb9ce8fb7a97d2e9905f64acec40df2 feel free to reopen this issue if you are still have problems.