search

scotch / angular-brunch-seed

AngularJS + Brunch
Other
228 stars 78 forks source link

bootstrap icons are not available #83

Open fijolekProjects opened 10 years ago

fijolekProjects commented 10 years ago

I can't get angular-brunch-seed (v0.4.0) to work with bootstrap-less icons (or regular bootstrap installed manually with bower). They are not included in _public folder. The only workaround I found was to include bootstrap cdn link in app.less, but it's not pretty.

kylefinley commented 10 years ago

Hey @fijolekProjects,

Yes, I'm aware of this. I haven't found a good solution yet. The problem is bower doesn't provide a way to specify assets (e.g. font files, *.png's, etc). So we can't automatically include them, when a file is added to .bower.json The short term solution is to include the icon files in the app/app/assets folder, but I was hoping to come up with something better. Do you have any thoughts on the best way to handle this?

fijolekProjects commented 10 years ago

I've put my icon png file in app/assets/icons and then in styles/_overrides.less I've overridden icons url like this:

[class^="icon-"],
[class*=" icon-"] {
  background-image: url("../icons/glyphicons-halflings.png");
}

Ok, it's not pretty, but I haven't thought about it before and it definitely works. Thanks!