search

scotch / angular-brunch-seed

AngularJS + Brunch
Other
228 stars 78 forks source link

Modularizing the code, using ui-router, demonstrating DRY tests, etc. #88

Open sanfordredlich opened 10 years ago

sanfordredlich commented 10 years ago

Hi Kyle,

Ok, here are the changes we talked about. What do you think?

There's an integration test added, btw, for a long-standing bug that happens if you add an item, switch to a view, then come back to "todo". There's also a fix for that now, which demonstrates Misko's comment that views referencing a model should always have a "dot", like "appData.todos". For some reason, though, it works by hand but the test fails. I'll look into that.

Cheers,

kylefinley commented 10 years ago

Sanford,

Nice Job! It will take me a little while to go through everything, I'll try to get it merged over the weekend, though.

Thanks again!

sanfordredlich commented 10 years ago

Cool, thanks Kyle. Let me know if I can help with anything. I tested install, running server.sh and running both kinds of tests. Cheers, - S.

sanfordredlich commented 10 years ago

Btw, on the last commit I just copied all of angular-brunch-seed into my fork, then updated the necessary files individually, to avoid conflicts with your latest code. - S.

kylefinley commented 10 years ago

Hey @sanfordredlich,

Every thing looks good so far -- the only issue I need to resolve is with the partials compiling to separate files, but I think that's an issue that can be solved in jade-angularjs-brunch.

Considering that the core routing infrastructure will be removed from Angular 1.2. I'll probably wait to merge with master until after Angular 1.2 is released, which should be soon. I just wanted to give you and update, so you didn't think I forgot about it.