search

scotrug / darts

Dependency aware ruby tests
http://github.com/darts
MIT License
7 stars 1 forks source link

1.9 support #6

Open urfolomeus opened 12 years ago

urfolomeus commented 12 years ago

As RCov isn't currently supported by 1.9, it would seem that we have the following options: -

1) Continue to develop with RCov in 1.8 just now until we prove the concept and then hope that 1.9 support has been added or monkey patch RCov using Bruce Williams' patch

2) Swap to using SimpleCov or similar just now to make it easier to support 1.9 (although see comment in issue 4 on issues using Coverage)

3) Another option I haven't thought of yet. :)

mattwynne commented 12 years ago

SimpleCov isn't an option. I looked into it, and all it does is use the built-in Coverage API, which assumes one coverage recording per process. Once you get one set of results from the API, you can't start recording coverage again.

See https://github.com/ghnatiuk/continuous_coverage_test for @ghnatiuk's kind attempt to extend Ruby 1.9's built-in coverage API to work for us.

mattwynne commented 12 years ago

It's also worth noting that, in practice, it seems to be working fine under 1.9 - tests passing etc. I used it on the Relish codebase without any problems, though I can't vouch for the accuracy of the results.

urfolomeus commented 12 years ago

How did you get the RCov gem installed? Copy a gem set from a 1.8 ruby to a 1.9 one? I was getting an error in both bundler and ruby gems when trying to install directly into a 1.9 ruby.

cheers,

Alan

On Monday, 23 January 2012 at 10:39, Matt Wynne wrote:

It's also worth noting that, in practice, it seems to be working fine under 1.9 - tests passing etc. I used it on the Relish codebase without any problems, though I can't vouch for the accuracy of the results.

Reply to this email directly or view it on GitHub: https://github.com/scotrug/darts/issues/6#issuecomment-3611875

mattwynne commented 12 years ago

Interesting, I didn't see anything like that. It might be that I tricked it my having the gem in vendor/cache from a 1.8 installation. Try that? You can use bundle install --local to stash things in vendor/cache - works well on trains :)

Obviously not a very good long term solution though if others can't install it. Hmph.

urfolomeus commented 12 years ago

Ah good thinking :) Thanks will give that a go.

cheers,

Alan

On Monday, 23 January 2012 at 10:44, Matt Wynne wrote:

Interesting, I didn't see anything like that. It might be that I tricked it my having the gem in vendor/cache from a 1.8 installation. Try that? You can use bundle install --local to stash things in vendor/cache - works well on trains :)

Obviously not a very good long term solution though if others can't install it. Hmph.

Reply to this email directly or view it on GitHub: https://github.com/scotrug/darts/issues/6#issuecomment-3611937