scott-griffiths / bitstring

A Python module to help you manage your bits
https://bitstring.readthedocs.io/en/stable/index.html
MIT License
401 stars 67 forks source link

Test failures due to lack of gfloat formats import #328

Closed kitterma closed 2 months ago

kitterma commented 2 months ago

When running the 4.2.1 test suite with gfloat 0.1, I get multiple errors:

AttributeError: module 'gfloat' has no attribute 'formats'

Inspecting src/gfloat/init.py, it says:

# Don't automatically import from .formats.
# If the user wants them in their namespace, they can explicitly import
# from gfloat.formats import *

Adding this to tests/test_fp8.py does solve the problem. I checked and this comment is still present in their current git, so it doesn't seem to be a temporary decision.

scott-griffiths commented 2 months ago

Thanks - this has addressed on the main branch already as it broke my build shortly after 4.2.1 was released (see 238770c)

I'm planning a point release at the weekend that should fix it for everyone else.

scott-griffiths commented 2 months ago

bitstring 4.2.2 is now released. 🎉