Closed scott-the-programmer closed 8 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
05337cd
) 82.75% compared to head (cdaa5c3
) 82.67%.:exclamation: Current head cdaa5c3 differs from pull request most recent head 72d0402. Consider uploading reports for the commit 72d0402 to get more accurate results
Files | Patch % | Lines |
---|---|---|
minikube/resource_cluster.go | 86.36% | 2 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes https://github.com/scott-the-programmer/terraform-provider-minikube/issues/131
Currently, setting up multiple nodes with cni=auto exhibits inconsistent behaviour due to not providing enough information to chooseDefault function in minikube.
There's 3 key pieces we're missing
A) the container runtime, which should default to docker (previously blank) B)
MultiNodeRequested
= true when multiple nodes are configured C) not defaultingnetwork_plugin
correctlyThis allows the downstream defaults to work correctly, likely configuring
kindnet
for multi node clusters.TODO: