search

scottbez1 / smartknob

Haptic input knob with software-defined endstops and virtual detents
https://www.youtube.com/watch?v=ip641WmY4pA
Other
19.4k stars 1.11k forks source link

simplyfoc library issue #140

Closed wangxinghe88 closed 1 year ago

wangxinghe88 commented 1 year ago

Askuric's simplyfoc project has been updated to 2.3.1 and there is changes in function's parameteres, which will generate error in the code. solution： In the platfromio.ini file, lib_deps should be changed to: askuric/Simple FOC@2.3.0

I think the typo "@^2.3.0" makes the version up to V2.3.1 unintentedly.

Edo78 commented 1 year ago

I think the issue is in Askuric's simplyfoc ... if a breaking changes is introduced (like a change in function's parameters) then he should have followed semantic version rules and not just bump a patch

runger1101001 commented 1 year ago

Yeah, sorry about that!

The changes were documented and announced, but we should pay attention to the version numbers as well.

I created a PR: https://github.com/scottbez1/smartknob/pull/142 this fixes the compile errors, but as I don't have a smartknob I can't test it out...