scottbez1 / splitflap

DIY split-flap display
https://scottbez1.github.io/splitflap
Other
3.09k stars 257 forks source link

Add more tolerance to cavity_top_allowance #124

Closed lastcoolnameleft closed 3 years ago

lastcoolnameleft commented 3 years ago

I think the default should add a bit more tolerance to the hight of the cavity. I just printed it and it's about 3 cards too low for me. Perhaps the vinyl added unexpected thickness. I think 3mm extra should be good.

dmadison commented 3 years ago

Do you have a pair of calipers to measure the thickness of your vinyl? If the cavity is too short I don't think the right solution is to adjust the amount of extra at the top, it's probably better to change the flap thickness allowance so it works for any number of flaps.

lastcoolnameleft commented 3 years ago

The cavity is short by only 3 cards, so I think I have it on the right way around.

Thanks for the suggestion. I've changed the code so that it changes flap_thickness_allowance instead. My cards vary between 1.1 and 1.2 depending on the placement and lip of the vinyl. I'm using cards purchase from @scottbez1 and vinyl stickers from the Ordering guide (Amazon link).

dmadison commented 3 years ago

The cavity is short by only 3 cards, so I think I have it on the right way around.

Yeah sorry about that - in my haste I thought you were talking about the lip on the enclosure. Serves me right for replying without checking what file you modified :sweat_smile:

I'm using cards purchase from @scottbez1 and vinyl stickers from the Ordering guide

Then I think modifying the thickness is definitely the way to go. I designed the container based off the thickness of my own flaps, and I cut my own letters from a vinyl roll so they're probably on the thinner side.