search

scottbucher / BirthdayBot

Discord Bot - Track and celebrate birthdays in your discord server!
https://discord.com/api/oauth2/authorize?client_id=656621136808902656&permissions=268659792&scope=bot
73 stars 13 forks source link

Incorrect handling of Feb 29th #192

Closed greebowarrior closed 2 years ago

greebowarrior commented 2 years ago

Alerts should be sent on Feb 28th, not March 1st in non-leap years

RafaCintron commented 2 years ago

People born on february 29 were born the day AFTER february 28, which corresponds to march 1 on non leap years.

greebowarrior commented 2 years ago

Trust me when I say I have a very deep insight into this matter, the majority of us celebrate on Feb 28th, as "last day of February" is always an accurate statement. Additionally, 365 days after February 29th is February 28th. Non-leaplings don't shift their birthday along following a leap day

scottbucher commented 2 years ago

The next update changes Feb 29th birthdays to be celebrated on the 28th. See 7bda933. I will most likely make this customizable in the future if there is interest in it (Make an issue/suggestion if you are interested in it so I remember lol).

greebowarrior commented 1 year ago

Can confirm this is now working as expected