scottburton11 / burger-time

D&D 5e Hunger rules for Foundry VTT
MIT License
3 stars 0 forks source link

Tracking, but not prompting? #5

Open Heljspe opened 3 years ago

Heljspe commented 3 years ago

Using the game.BurgerTime.showHungerTable() Macro I can see in the table it's tracking 'Hours Ago' and 'Hunger' Level, but not got any value for 'Last Meal' or 'Last Notified'.

In the image below - CARL is the active player image

Using Small Time, About Time, Simple Calendar, Foundry 0.8.6, DnD5e 1.3.6

jesucar3 commented 3 years ago

try updating foundry to 0.8.8

jesucar3 commented 3 years ago

its fixed on the last version i think

scottburton11 commented 3 years ago

Hi @Heljspe there's a fix coming soon for some other 0.8.x compat issues, but in the meantime here's a script that will reset hunger for the selected token's actors:

canvas.tokens.controlled.forEach(async token => {
  const actor = game.actors.get(token.actor.data._id)
  await game.BurgerTime.resetHunger(actor)
})
Heljspe commented 3 years ago

Updated to Foundry 0.8.8 Updated Mod (through 'the Forge' Bazaar) to 0.1.8 AboutTime 1.0.3, SmallTime 1.9.9, Simple Calendar 1.2.113 Ran script above Ran both the scripts in the resetHunger method. Tried with different players (realised I was using a warforge character that doesnt need to eat, thought maybe the mod was THAT awesome, but its not working with a human or leonin either). Tried different scene, active/inactive scenes. Gave player ALL the permissions

Show burger time table is correctly tracking 'Hours Ago' for active tokens controlled by a player, but not applying exhaustion for Hunger levels, not showing notifications, and not tracking 'Last Meal' or 'Last Notified' (assuming because it's NOT notifying). Eating Rations doesn't reset hunger.

Hit F12 and can't see any errors in console, but lots of notifications that about-time is now depreciated?

Sorry to be such a hassle, I'm not even really sure what information helps and what doesn't. This looks like a really awesome mod, thank you for taking the time to help and responding so quickly! :) Not sure if the update your mentioning was the one just gone or another one coming, apologies if this is already being addressed and I'm just impatient. ^^"

scottburton11 commented 3 years ago

Hey no problem @Heljspe thanks for the detail. Couple of things to try:

The latest release (0.1.8) should have fixed a number of issues with the latest Foundry. Also, keep an eye out for 0.1.9 which should fix some issues with the hunger table.

Heljspe commented 3 years ago

Installed 0.1.9. Booted up a test world with all the modules turned off expect about time, burger time, simple calendar, small time. Gave players ALL the permissions.

Thinking it's maybe my 'rations' item that's not working? Made a player and gave them two sets of rations. One with the details below, one with nothing but the name filled in but set as type 'food' and a third with just the name.
image

scottburton11 commented 3 years ago

If it is tracking hunger (you can see "Hours Ago" advancing in the Hunger Tracker) but not notifying you, there may be a bug in the evaluation stage. Weirdly that's in a different area of the code than consuming rations is, so it could be two separate problems.

I'm assuming, since the hunger level is increasing, that you have both the GM and the player logged in?

Could you please do me a favor and check the Developer Tools console for any red text during these times:

Thanks for pointing out Consumable Details - I didn't know about "Consumable Type"! I'll try to work that into a future build. For now, please check the Burger Time module settings and double-check that "Ration Name" has a value and that it is "Rations" or matches your food item name.

image

Thanks again for the troubleshooting steps!

Heljspe commented 3 years ago

I had a look through the console and this was the only error - which I've traced to this spot in the code? Maybe that helps? :) image image

Ration name matches ration item - I made sure to edit the item and then just copy-paste the name across (just in case). :p

Heljspe commented 3 years ago

Ah - yes. If it helps. Im logging in as the GM on chrome and as a player on edge. :p So I can have the player 'active' and see both POV. Have tried Chrome + Incognito mode chrome, but that didn't change anything.