search

scottchiefbaker / ESP-WebOTA

Simple web based Over-the-Air (OTA) updates for ESP based projects
MIT License
283 stars 38 forks source link

A couple of warnings #5

Closed AlexFundorin closed 4 years ago

AlexFundorin commented 4 years ago

These are the ones I'm getting while compiling the sketch.

lib\ESP-WebOTA\src\WebOTA.cpp: In member function 'int WebOTA::handle()':
lib\ESP-WebOTA\src\WebOTA.cpp:61:14: warning: unused variable 'init_run' [-Wunused-variable]
  static bool init_run = false;
              ^
lib\ESP-WebOTA\src\WebOTA.cpp:72:1: warning: no return statement in function returning non-void [-Wreturn-type]
 }
 ^
lib\ESP-WebOTA\src\WebOTA.cpp: In member function 'int WebOTA::add_http_routes(WebServer*, const char*)':
lib\ESP-WebOTA\src\WebOTA.cpp:198:1: warning: no return statement in function returning non-void [-Wreturn-type]
 }
 ^
lib\ESP-WebOTA\src\WebOTA.cpp: In function 'int init_wifi(const char*, const char*, const char*)':
lib\ESP-WebOTA\src\WebOTA.cpp:256:1: warning: no return statement in function returning non-void [-Wreturn-type]
 }
 ^
scottchiefbaker commented 4 years ago

Good catch... I just landed ca6c74b which should fix this. Want to test it out for me?

AlexFundorin commented 4 years ago

Yep. The warnings are gone now.

scottchiefbaker commented 4 years ago

Thanks for the report. Otherwise is the module working for you?