scottchiefbaker / dool

Python3 compatible fork of dstat
GNU General Public License v3.0
332 stars 64 forks source link

diskset option requires spaces in between disks #44

Closed Mossop closed 1 year ago

Mossop commented 1 year ago
SUMMARY

The diskset option is documented as --diskset name:sda,sdb but in fact in order to work you have to pass as --diskset "name:sda, sdb", note the added space after the comma and the required quotes.

ISSUE TYPE
DSTAT VERSION
Dool 1.2.0
Written by Scott Baker <scott@perturb.org>
Forked from Dstat written by Dag Wieers <dag@wieers.com>
Homepage at https://github.com/scottchiefbaker/dool/

Platform posix/linux
Kernel 5.15.0-522304060810-generic
Python 3.10.6 (main, May 29 2023, 11:10:38) [GCC 11.3.0]

Terminal type: screen (color support)
Terminal size: 63 lines, 212 columns

Processors: 4
Pagesize: 4096
Clock ticks per secs: 100

internal:
    aio,cpu,cpu-adv,cpu-use,disk,epoch,fs,int,io,ipc,load,lock,mem,mem-adv,net,page,proc,raw,socket,swap,sys,tcp,time,udp,unix,vm,vm-adv,zones
/home/dave/.dool:
    battery,battery-remain,bond,condor-queue,cpufreq,dbus,disk-avgqu,disk-avgrq,disk-svctm,disk-tps,disk-util,disk-wait,dool,dool-cpu,dool-ctxt,dool-mem,fan,freespace,fuse,gpfs,gpfs-ops,
    helloworld,ib,innodb-buffer,innodb-io,innodb-ops,jvm-full,jvm-vm,lustre,md-status,memcache-hits,mongodb-conn,mongodb-mem,mongodb-opcount,mongodb-queue,mongodb-stats,mysql-io,mysql-keys,
    mysql5-cmds,mysql5-conn,mysql5-innodb,mysql5-innodb-basic,mysql5-innodb-extra,mysql5-io,mysql5-keys,net-packets,nfs3,nfs3-ops,nfsd3,nfsd3-ops,nfsd4-ops,nfsstat4,ntp,postfix,power,
    proc-count,qmail,redis,rpc,rpcd,sendmail,snmp-cpu,snmp-load,snmp-mem,snmp-net,snmp-net-err,snmp-sys,snooze,squid,test,thermal,top-bio,top-bio-adv,top-childwait,top-cpu,top-cpu-adv,
    top-cputime,top-cputime-avg,top-int,top-io,top-io-adv,top-latency,top-latency-avg,top-mem,top-oom,utmp,vm-cpu,vm-mem,vm-mem-adv,vmk-hba,vmk-int,vmk-nic,vz-cpu,vz-io,vz-ubc,wifi,
    zfs-arc,zfs-l2arc,zfs-zil
OS / ENVIRONMENT

Running on macOS 13.4.1 (22F82)

STEPS TO REPRODUCE

I attempted to separate out my SDD and the disks forming my ZFS pool with the following command:

dool --cpu --net --disk --disk-tps --bytes --diskset sdd:sda --diskset 'zfs:sdb,sdc,sdd,sde,sdf,sdg,sdh'
EXPECTED RESULTS

I should have seen IO operations for the zfs set.

ACTUAL RESULTS

The zfs set showed no operations whatsoever. Creating a set for each of the disks individually worked. Looking at the code parsing the arguments it is splitting on ", " so I tried adding spaces in between the disks in the disk set and that worked.

scottchiefbaker commented 1 year ago

Good catch. This should be corrected in f9fe798.