scottchiefbaker / dool

Python3 compatible fork of dstat
GNU General Public License v3.0
325 stars 64 forks source link

Plugins not available when installing via pip #73

Closed benfishbus closed 1 week ago

benfishbus commented 1 month ago
SUMMARY

Many (all?) plugins give an error when Dool is installed using pip.

ISSUE TYPE
DOOL VERSION

1.3.2

OS / ENVIRONMENT

Platform posix/linux Kernel 6.1.79-Unraid Python 3.9.10 (main, Jan 16 2022, 02:41:55) [GCC 11.2.0]

STEPS TO REPRODUCE
pip install dool
dool --top-io
EXPECTED RESULTS

Start the top-io plugin.

ACTUAL RESULTS

dool: option --top-io not recognized, try dool -h for a list of all the options

scottchiefbaker commented 1 month ago

Dool checks for plugins in:

    os.path.expanduser('~/.dool/'),                              # home + /.dool/
    os.path.abspath(os.path.dirname(sys.argv[0])) + '/plugins/', # binary path + /plugins/
    '/usr/share/dool/',
    '/usr/local/share/dool/',

Do you see any files in any of those locations? Running dool --version will list all the plugins it finds, and what directory they're located in.

raylu commented 1 month ago

oh I knew about this when I set up the packaging. see #50

the main problem, though, is plugins/. it can't find any after installing

I wrote some more about what it would take to make the plugins installable and importable, but after

The plugins are nice, but not required.

I decided to forget about it

scottchiefbaker commented 1 month ago

@raylu is this something we want to include in the next version that gets published? I don't know how complicated it would be.

raylu commented 1 month ago

@benfishbus give https://test.pypi.org/project/dool/1.3.3/ a whirl

scottchiefbaker commented 3 weeks ago

@benfishbus is this issue resolved?

benfishbus commented 1 week ago

Had to educate myself on installing stuff from test. It is working for me!