search

scottcorgan / angular-scrollto

Angular directive to scroll to element by selector.
MIT License
54 stars 10 forks source link

Create config for settings. #7

Open dietergeerts opened 9 years ago

dietergeerts commented 9 years ago

Hi, Great directive! Simple and effective, better than other I could find, especially because the hash isn't shown in the location and you can use any css selector.

One 'problem' though. I would like to use some other default values, like for example the offset. Now I need to add this every time. So could you expose a config to configure these defaults?

scottcorgan commented 9 years ago

How would you like to see this config? During the config phase of Angular bootstrapping the app?

Let me know and I'll see what it will take to make that happen.

dietergeerts commented 9 years ago

Hi, I forked the project and already added the config. I used another fork as it has some bug fixes and a controller call added I would like to use. I did a pull request there first, Maybe after that one all those changes can be merged with the Original? (https://github.com/mkirchstein/angular-scrollto/pull/1) And npm update so I can include it in my project?

scottcorgan commented 9 years ago

I'd like to see that merged into this repo as well, but I've got no pull request. @mkirchstein, want to submit a PR with your fixes?