search

scottcorgan / tap-out

A different tap parser
MIT License
23 stars 28 forks source link

Fix event issues to print results #32

Open r0mflip opened 5 years ago

r0mflip commented 5 years ago

This tries to solve the problems discussed in https://github.com/substack/tape/pull/465 and https://github.com/substack/tape/pull/466

Piping to split() and listening to end or close events doesn't work because tape emits end when the process exits. Explicitly writing data to splitStreamemits the events at right time. It's better to use the the end event than close because by the time close occurs the process is in the state of dying and the output to stdout is lost.

r0mflip commented 5 years ago

/pinging @scottcorgan

r0mflip commented 5 years ago

/pinging again @scottcorgan

spencermountain commented 3 years ago

hey @r0mflip I'd like to include this fix in a fork, but I've updated readable-stream and I may need your help. Care to take another shot at this? cheers!

r0mflip commented 3 years ago

Hi @spencermountain I've been off-of this project and tap for a while now (my my, 2 years). But let me know how I can help.