scottcorgan / tap-out

A different tap parser
MIT License
23 stars 28 forks source link

support HTTP source for error #7

Closed mattdesl closed 9 years ago

mattdesl commented 9 years ago

I'm working on some browser based tap tools and tap-parser has a hard time parsing errors that come from a URL like this:

http://localhost:9966/bundle.js:20:5

The at: ... field gets messed since it just splits on ':'.

This PR fixes it without breaking the existing tests. If you have a better approach (i.e. using regexes or something) I'm all ears. :smile:

scottcorgan commented 9 years ago

Looks good. Published as 1.2.1.

mattdesl commented 9 years ago

:+1: thanks for the speedy merge