scottdevoss / viewing_party_lite_7

1 stars 1 forks source link

Dashboard page #14

Closed coryrpow closed 1 year ago

coryrpow commented 1 year ago

Cory Wrote Tests

Necessary checkmarks:

[x] All Tests are Passing

[x] The code will run locally

Type of change

[x] New feature
[] Bug Fix

Implements/Fixes:

I added testing for the Dashboard page as well as the discover page routing. I took the discover page to be a movie related thing and named the controller movies, but we can always refactor if we change our minds on that. I had an annoying time working around the rubocop gem, not sure if you did as well, but I think that will be something to refactor and keep up with just to avoid the demonic little blue squiggles all over.

I also removed a line of code in the index_spec that related to checking for an email to be present in the show spec, as it didn't call for it.

Check the correct boxes

[x] This broke nothing
[] This broke some stuff
[] This broke everything

Testing Changes

[] No Tests have been changed
[x] Some Tests have been changed
[] All of the Tests have been changed(Please describe what in the world happened)

Checklist:

[] My code has no unused/commented out code
[x] I have reviewed my code
[] I have commented my code, particularly in hard-to-understand areas
[x] I have fully tested my code

(For Fun!)Please Include a link to a gif of your feelings about this branch

Link: