scottdrichards / MMM-SimpleBGSlideshow

MIT License
3 stars 0 forks source link

Help please #2

Open Craig43 opened 1 year ago

Craig43 commented 1 year ago

Like your slide show module. Works well. I do have a question about it. All the images i load, both landscape or portrait orientation, are stretched to larger than the screen. I would prefer the images not stretched. Where a border is needed black would be great. Is there something I need to do in the CSS file?
Thanks Craig

davidkindred commented 4 months ago

Craig, if you weren't able to find a solution, you might consider doing what I did. I used a free media manager program (specifically, digiKam) to export copies of all of my photos in a consistent 1080 pixel resolution and used those copies for the MM.

Elwin-M commented 4 months ago

I know according to the MagicMirror documentation you should be able to use a custom CSS to override the defaults for modules, but I never bother too much with it. If you modify line 37 in the style.css file from cover to contain, you should be able to achieve what you're looking for. Any of the regular css image styles work here.

.MMM-SimpleBGSlideshow img{ object-fit: contain; }

davidkindred commented 4 months ago

Clever--thanks! I'm working through Scott's code now trying to work out some of the details. I'd like to add some functionality to show the images in random order. If I'm successful, maybe we can add that capability and your modification here to the code base.

It looks as if Scott may have abandoned this code. He mentioned something about getting a cold reception on the MM forum, which I don't understand. I really like what he's done with the slideshow. It works well, his code is well-written, and his documentation is also good. I wonder what was up with those people several years ago?

[Scott, if you are receiving this notification, please know that I am quite grateful for your excellent work!]