scottdurow / NetworkViewPCF

Model Driven Power App PCF Control to show a network diagram of records
MIT License
29 stars 9 forks source link

Account Connections not showing on Contact if Company is Empty #9

Open Justinaime opened 4 years ago

Justinaime commented 4 years ago

Hi Scott,

Thanks so much for the PCF control. I have noticed that when a contact has an Account connection, it does not display on the Network View Pcf if the Company Name (parentcustomerid) field on Contact is empty.

Is there a way to always display the connection even if the Company Name (parentcustomerid) field is empty?

Thank you for your assistance.

Regards,

Justin

scottdurow commented 4 years ago

Definitely should be showing contacts if the parent company is not filled out! I'll look into this.

Justinaime commented 4 years ago

Hi Scott,

Thank you so much for your prompt response. It was also a weird one and while troubleshooting, I picked that one up. Just to clarify:

Hope there is clarity, if not please let me know.

Thank you so much for your work and prompt assistance.

Regards,

On Fri, Sep 25, 2020 at 1:47 AM Scott Durow notifications@github.com wrote:

Definitely should be showing contacts if the parent company is not filled out! I'll look into this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/scottdurow/NetworkViewPCF/issues/9#issuecomment-698643433, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQU3FRT3CBV5GJZB7MLI7ATSHPK73ANCNFSM4RQC77PQ .

PradeepPeriVenkata commented 3 years ago

The below configuration at Defaultconfig.ts at contact level is causing an issue with a condition at line 261 at queueprocessor.ts

{ leftEntity: "account", leftAttribute: "accountid", rightEntity: "contact", rightAttribute: "parentcustomerid", },

failing condition- if ( lookupValue && lookupValue.id && lookupValue.entityType && lookupValue.entityType == link.linkSettings.leftEntity lookupValue.entityType == link.linkSettings.leftEntity this is failing and hence the node is not added as a link

i have made a intermin fix for me like below to work if ( lookupValue && lookupValue.id && lookupValue.entityType && ((lookupValue.entityType == link.linkSettings.leftEntity) || (lookupValue.entityType == "account" && link.linkSettings.leftEntity == "contact" )) ) then it picks up the connections related to accounts also...then you dont need primarycustomer filled in hope this helps!

ciaomatteo commented 1 year ago

@PradeepPeriVenkata : Thanks, this fix is working in my case.