scottdurow / RibbonWorkbench

Ribbon Workbench 2016 for Dynamics 365
https://ribbonworkbench.uservoice.com/
MIT License
72 stars 24 forks source link

CommandValueId missing for Button #11

Open rappen opened 7 years ago

rappen commented 7 years ago

We are using attribute CommandValueId on Button elements to pass button specific information to javascript methods to implement generic methods that behave differently depending on this value. This is also very good when dynamically populating flyouts. Documentation on button attributes: https://msdn.microsoft.com/en-us/library/gg334536.aspx Documentation on CrmParameter: https://msdn.microsoft.com/en-us/library/gg309332.aspx

In RibbonWorkbench this attribute is not visible, and I have a gut feeling the attribute is removed entirely if using RWB to update a solution.

Could support for CommandValueId be implemented in RWB? :)

scottdurow commented 7 years ago

Hi Jonas, The Ribbon Workbench shouldn't remove it if you have it already in your xml - if it does, then it's a bug!

Have you had success using CommandValueId in all versions of Dynamics? I stopped using it myself back in CRM2015 because it stopped working in some situations. Instead I use the Button ID.

rappen commented 7 years ago

Hi Scott, Yes, I recall we had a discussion about this a couple of years ago... Aparently I had forgotten that it did not work when I recently started designing new buttons and used this feature - and it definitely works now in 2016, I guess in 365 too...

scottdurow commented 7 years ago

That is good to know! You can look forward to the return of this attribute in the next version!

rappen commented 7 years ago

Lovely! 👍