scotteuser / open_citations

Batch processing demo using the OpenCitations API as a real-world use case.
2 stars 2 forks source link

Is there a limit, with max citations = 3? #2

Closed achourasia closed 2 years ago

achourasia commented 2 years ago

Is there a limit imposed to fetch a maximum of three citations for any publications? On repeated triggers via UI or drush no new citations are added to the publications.

For example, open citations own example with DOI 10.1186/1756-8722-6-59 has 66 citations, but the module only fetches the following three

10.1016/j.biopha.2017.01.070Receptor Tyrosine Kinase-Like Orphan Receptor 1 (Ror-1): An Emerging Target For Diagnosis And Therapy Of Chronic Lymphocytic Leukemia 10.1016/j.bmcl.2015.01.032Potent And Selective Bruton’S Tyrosine Kinase Inhibitors: Discovery Of Gdc-0834 10.1016/j.bmc.2019.06.023Discovery And Biological Evaluation Of Pyrimido[4,5-D]Pyrimidine-2,4(1H,3H)-Dione Derivatives As Potent Bruton’S Tyrosine Kinase Inhibitors

scotteuser commented 2 years ago

Yep it's https://github.com/scotteuser/open_citations/blob/main/src/OpenCitationsClient.php#L70 there is an arbitrary limit applied to be kind to their API when demoing it. Similarly you'll find a sleep() higher up in the same file with a similar comment.

achourasia commented 2 years ago

Great thanks for pointing out max and sleep lines. I grep'ed for max in the code, but missed out that line.