scottgchin / delta5_race_timer

Multi-node video transmitter race timer for drone racing
MIT License
159 stars 62 forks source link

Support for saving Tune Params for different VTX power #53

Closed lephiloux closed 6 years ago

lephiloux commented 6 years ago

This pull request adds the ability to save params in DB and enable a set of values for different vtx power environments.

scottgchin commented 6 years ago

Just a thought, what if instead of default settings for 25, 200, and 600; a user could set up different profiles? For example, we have different locations with different RF environments , but if I could store track 1-25mw, track 1-200mw, track 2-25mw, etc. That would be pretty cool.

lephiloux commented 6 years ago

Just a question what relation should we use ? I see two way to do it.

First: We use flat profile table with the following entries.

Second we have a profile table, with track table, with tune params table

The profile table:

The track table:

The tune params table:

First option is easier in terms of gui, user, development . Second option is more flexible put more difficult to develop and in term of ui not so easy to have something easy to understand for user and probably a new html page will be needed.

What's your opinions about this ?

scottgchin commented 6 years ago

I would say go with the first option to keep it simple. What i'm picturing is that a user can adjust the parameters to fine tune, then they can hit a save button to add it to a profile, or something similar.

lephiloux commented 6 years ago

Done :-)