scottgchin / delta5_race_timer

Multi-node video transmitter race timer for drone racing
MIT License
159 stars 62 forks source link

Livetime interface updates #78

Open ErikBorra opened 6 years ago

ErikBorra commented 6 years ago

This pull request includes the timingserver layout from @basdelfos (up til #67f5736), including:

I have further tweaked it by

punkkills commented 6 years ago

Hey @ErikBorra, I'll give this change a more in depth view when i have some time. Out of curiosity, what value do you find that these changes add? When I built this page, the intent was a place to test out the Socket.IO API as I was working with Cory for the Livetime integration. I didn't really intend this page to be a long lived user facing UI. All of these values are easily accessible from LiveTime. If the value is the shutdown and temperature reading, those are things better requested from LiveTime, IMO.

ErikBorra commented 6 years ago

Hi @punkkills,

thanks for your feedback. There are a few uses for the page:

scottgchin commented 6 years ago

I agree with @punkkills that this page shouldn't be used to change the timer settings, as these are available through Livetime. But I think there are items that are helpful like the graphs. I was planning on officially adding those at some point (it was already there, just not linked). I also want to add the LED controls since LiveTime has limited commands.

What if we do both? Remove the timer settings, and reconfigure the page to show the graphs and the LED controls?

ErikBorra commented 6 years ago

Why should the timer settings not be changed through that page? It doesn't hurt, does it? Actually, I find it easier to change the settings via the page, as you get the direct visual feedback of the three coloured bars (rssi peak, calibration offset, current rssi) below.

basdelfos commented 6 years ago

I have an updated version of my original version of this page which also displays the looptime per node and also displays the input voltage (handy when using a lipo to power the Delta 5 or when using PoE adapter with very long UTP cable). The input voltage requires a hardware mod with voltage divider and an updated sketch on node 4.

I can upload the changes to github when interested.

ErikBorra commented 6 years ago

Hi @punkkills,

thanks so much for your time and feedback. I'm sure many would love to have the LiveTime integration be better.

From the top of my head, the following would be great to have in LiveTime:

Currently LiveTime only sends a message to delta 5 when a race has started (by calling reset_calibration in server.py). For integration with the led functionality, It'd be awesome if LiveTime could also indicate to delta5:

Last, but not least, if @lephiloux 's per node tuning was added to @scottgchin's repo (see this commit]), it'd be great if we could do that via LiveTime as well.

Shall I open an issue to discuss this, instead of discussing this here?

basdelfos commented 6 years ago

I've just merged the voltage and looptime monitoring to master of my fork. https://github.com/basdelfos/delta5_race_timer

lephiloux commented 6 years ago

It’s as you want , issue or here both are fine for me ;-)

Envoyé de mon iPhone

Le 2 mai 2018 à 09:26, Erik Borra notifications@github.com a écrit :

Hi @punkkills,

thanks so much for your time and feedback. I'm sure many would love to have the LiveTime integration be better.

From the top of my head, the following would be great to have in LiveTime:

shutdown / restart temperature voltage reading (as @basdelfos has implemented) indicators for current rssi, peak rssi and calibration offset a button to 'copy event frequencies' like with the 8-way laprf Currently LiveTime only sends a message to delta 5 when a race has started (by calling reset_calibration in server.py). It'd be awesome if LiveTime could also indicate to delta5:

when a race has completed the colours associated to a specific frequency (for integration with the led functionality) Last, but not least, if @lephiloux 's per node tuning was added to @scottgchin's repo (see this commit]), it'd be great if we could do that via LiveTime as well.

Shall I open an issue to discuss this, instead of discussing this here?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.