[Request] Korean-Japanese Support

[ghost]

Hi, I was impressed by your addon "Korean-Support" because it had all the features I was looking for, except it does not support Japanese learning. It would be greatly appreciated if you could make the exact same kind of add-on but with a Japanese-Korean NAVER dictionary, or even just a brief explanation on how you made the add-on so that I could customize it. Thanks!

[scottgigante]

Hey @railame , sorry for the slow response here. Unfortunately I don't have much time to work on this add-on anymore. If anyone wants to look into this, I will happily accept a PR.

[phil-markarian]

@scottgigante I am interested in implementing this feature. Although my programming experience with python is quite limited, I might be able to figure something out. I liked the features your add-on has and would like to use it to learn Korean from Japanese.

[scottgigante]

Hi @phil-markarian, I'd be happy to point you to the relevant parts of the code.

• In https://github.com/scottgigante/korean-support/blob/master/korean/edit_functions.py , add a new function called japanese that fetches the JP-KO translation of a word. You may do this however you like -- in English, we do this with a local dictionary from https://github.com/scottgigante/kengdic but you may for example pull from Naver Translate.
• Add a test_japanese test in https://github.com/scottgigante/korean-support/blob/master/tests/test_edit_functions.py#L76 to ensure it does what you expect
• Add an option to select the JP-KO dictionary in the UI: https://github.com/scottgigante/korean-support/blob/master/korean/ui.py#L22 -- say we call it naver_jp
• In update_Meaning_fields at https://github.com/scottgigante/korean-support/blob/master/korean/edit_behavior.py#L27, add an if statement to check the value of config.options["dictionary"]: if it's local_en, follow the current flow (m = english(hangul)). If it's naver_jp, get the value from your new japanese function.

Feel free to ping me if you have questions / issues.

[phil-markarian]

@scottgigante Thanks for the detailed reply. It's a big help. I should have some time next month to work on it. I'll let you know when I make a PR.

P.S it's my first time contributing to a project outside of work, so might take me a bit to get the hang of things.