Crashes in Anki 23.10 - Githubissues

scottgigante / korean-support

Anki add-on providing support for Korean study

https://ankiweb.net/shared/info/1336389630

GNU General Public License v3.0

20 stars 5 forks source link

Crashes in Anki 23.10 #39

Closed ajdubovoy closed 9 months ago

ajdubovoy commented 11 months ago

Seems like the Korean add on crashes in Anki 23.10. I get a popup when I open Anki that it failed to load this add on.

scottgigante commented 11 months ago

Hi @ajdubovoy , thanks for the flag. Unfortunately I don't have the time to update this package at the moment, though I will happily accept a pull request.

ajdubovoy commented 11 months ago

No worries. Thanks for letting me know. I have no experience building Anki extensions, but I am a web developer and could probably figure it out. Would be happy to help

threkk commented 10 months ago

I have managed to get a working version of the add-on on my machine. It nails down to updating the references of PyQT5 to PyQT6, and updating the gTTS submodule, so it removes the dependency on six. I was working on a patch, but the submodule set up got on the way. With the right ownership of the different repositories is 10 minutes work.

scottgigante commented 10 months ago

@threkk could you open a PR with the changes you made? I'm happy to do the rest.

threkk commented 10 months ago

That would be an overkill, as I only replaced PyQt5 with PyQt6 here.

Regarding gTTS, for my local installation, as I cannot easily update the package, added six as a package. This should not be needed if you can update the dependency because upstream six is not a dependency any more.

The gist of the problem seems to be that with the release of the latest versions of Anki, they replaced QT5 with QT6, and removed the support for Python 2, which also removed the six library. The current version upstream of gTTS does not use six, but the one pinned in the submodule does.

scottgigante commented 10 months ago

I tried the solution you suggested, but unfortunately in the intervening time both formatting and CI have become outdated and will need to be fixed (see https://github.com/scottgigante/korean-support/pull/40). I don't have any bandwidth to work on this -- I don't use Anki anymore nor do I study Korean, so I'm only maintaining this out of goodwill. I'm happy to review and merge PRs. You would need to:

open a PR from gTTS head to my fork of gTTS as in https://github.com/scottgigante/gTTS/pull/1 (conflicts need resolving)
open a PR to this repo updating PyQT6, fixing CI / linting errors, and updating the commit of the subrepository to the new merged head of my fork of gTTS

I will happy review, merge and release if someone is willing to do this.

Kiina commented 9 months ago

I have created a merge request for gTTS. Did a test with my fork of korean-support with the CI errors and PyQT fixed and the TTS is generated. Can update the submodule in the fork when it's merged and do a pull request for korean-support.

scottgigante commented 9 months ago

Merged, thank you!

scottgigante commented 9 months ago

Thanks to @Kiina we now have a new version released on Ankiweb. Please let me know if the issue persists.