scottgigante / korean-support

Anki add-on providing support for Korean study
https://ankiweb.net/shared/info/1336389630
GNU General Public License v3.0
19 stars 5 forks source link

Latest update causes crash of this addon when Anki 2.1.35 loads #42

Closed cereska closed 7 months ago

cereska commented 7 months ago

Hi,

I have to stay on Anki 2.1.35 due to another addon not updating. When I updated Korean Support today, I got following error when the application loaded: obraz Can you please take a look what might be causing this? Many thanks in advance!

scottgigante commented 7 months ago

Thanks for letting me know -- I released a new version yesterday for compatibility with Anki 2.10 and this appears to have broken the older version.

I released a new version just now that should hopefully work on both branches. Can you please update it and let me know how it goes?

cereska commented 7 months ago

I updated the add-on and now another error shows up:

obraz

Kiina commented 7 months ago

I released a new version just now that should hopefully work on both branches. Can you please update it and let me know how it goes?

The bugfix broke all versions. Seems like anki wants from aqt.qt instead of from aqt.qt.QtWidgets. Downloaded an old qt5 anki version and it seems to work when applying that change.

scottgigante commented 7 months ago

Updated, please check again. Thanks

Kiina commented 7 months ago

Startup doesnt crash but about box is broken. I'm looking into it

cereska commented 7 months ago

It doesn't crash on load anymore for me :) Thanks a lot for a quick reaction!

scottgigante commented 7 months ago

Thanks for letting me know and thanks @Kiina for the quick PR!