search

scottgonzalez / pretty-diff

colorized HTML diffs
MIT License
218 stars 27 forks source link

Makes pretty-diff prettier #4

Closed nhunzaker closed 12 years ago

nhunzaker commented 12 years ago

I hope you'll excuse the additional annoyance, but I hated how Github handled the automatic pull request. I've cleaned it up a bit.

Basically, I ported over some styles from Github's diff page and set the body to have a max width of 800. This means that it will fill the container of the page until it exceeds 800px, something I find useful.

scottgonzalez commented 12 years ago

Ugh, spaces.

Overall I really like this. I've got a few changes I want to make, so I'll clean up the indentation while I do that. I think I'll also address #2 at the same time by adding a wrapper and putting min-width: 800px instead of the max-width that you've got on the body.

nhunzaker commented 12 years ago

I should have wrangled emacs better. Sounds good! On Jun 6, 2012 8:30 PM, "Scott González" < reply@reply.github.com> wrote:

Ugh, spaces.

Overall I really like this. I've got a few changes I want to make, so I'll clean up the indentation while I do that. I think I'll also address #2 at the same time by adding a wrapper and putting min-width: 800px instead of the max-width that you've got on the body.

Reply to this email directly or view it on GitHub: https://github.com/scottgonzalez/pretty-diff/pull/4#issuecomment-6166387

scottgonzalez commented 12 years ago

Landed in 55c9d488c0bb81c24860f7e5956e3504b11fe6bb with some changes.