search

scottgs / cvtile

GDAL + OpenCV + CUDA
BSD 3-Clause "New" or "Revised" License
10 stars 5 forks source link

Cleanup GPU Folder/tests to follow code standards in rest of project #12

Open ghost opened 9 years ago

ghost commented 9 years ago

Need to cleanup all the GPU code to look like the code in algorithm and base.

interputed commented 8 years ago

I have created a custom clang-format style guide for the project which is tailored to handle the long class definition lines quite well, and just makes the code completely consistent and more readable, subjectively. Here is an example file you can review and let me know what changes you guys would like to see with the style. https://github.com/interputed/cvtile/blob/library_fix/src/base/cvTile.hpp Speak now, or forever hold your peace!

ghost commented 8 years ago

Good idea! I'll take a look a bit later tonight.

-Eric

Sent from my iPhone

On Sep 1, 2016, at 9:44 PM, Andrew Craighead notifications@github.com wrote:

I have created a custom clang-format style guide for the project which is tailored to handle the long class definition lines quite well, and just makes the code completely consistent and more readable, subjectively. Here is an example file you can review and let me know what changes you guys would like to see with the style. https://github.com/interputed/cvtile/blob/library_fix/src/base/cvTile.hpp Speak now, or forever hold your peace!

― You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

ghost commented 8 years ago

All fine with me; I might modify it later, but every ide and vim has a clang-format plugin so every change is no biggie. Git hooks aren't a bad idea either, for that sort of thing.

On Thu, Sep 1, 2016 at 9:44 PM, Andrew Craighead notifications@github.com wrote:

I have created a custom clang-format style guide for the project which is tailored to handle the long class definition lines quite well, and just makes the code completely consistent and more readable, subjectively. Here is an example file you can review and let me know what changes you guys would like to see with the style. https://github.com/interputed/cvtile/blob/library_fix/src/base/cvTile.hpp Speak now, or forever hold your peace!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/scottgs/cvtile/issues/12#issuecomment-244261853, or mute the thread https://github.com/notifications/unsubscribe-auth/AHdlTVUStpkExmAjY8Oo0YbPOCjBlyAkks5ql39tgaJpZM4F0cur .

interputed commented 8 years ago

Unable to actually apply the style until the LBP and WHS branches are merged. Which could be a while.

nivintw commented 8 years ago

LBP is merged in.

nivintw commented 8 years ago

WHS might have to wait, as @interputed and I are working on another thing for a while.