search

scotthartbti / android_frameworks_base

Other
5 stars 28 forks source link

added and resized stat_sys_download for mdpi devices #1

Closed 7alvi closed 10 years ago

scotthartbti commented 11 years ago

I will take a look at this in a bit. Thanks.

scotthartbti commented 11 years ago

I actually just noticed that this is for the jb42 branch... Was this on purpose or an accident? The jb42 branch is not longer being supported and development has ended. All development has and will continue with the jb43 branch.

7alvi commented 11 years ago

It was on purpose. I wasn't aware that it was no longer in development. Without these re sized pngs it gives process.android.media FC while downloading anything (on mdpi devices, of course).

scotthartbti commented 11 years ago

This is the first I've heard of this... The regular pngs are straight from cm ... . I haven't done anything with the jb42 branch for about 2 weeks... Possible something else is causing the issue? I added these pngs to the jb43 branch and it produced a ton of image inflater errors while building... Ill take a peek at the cm end of things. On Aug 18, 2013 9:17 AM, "Vishal Khanna" notifications@github.com wrote:

It was on purpose. I wasn't aware that it was no longer in development. Without these re sized pngs it gives process.android.media FC while downloading anything (on mdpi devices, of course).

— Reply to this email directly or view it on GitHubhttps://github.com/scotthartbti/android_frameworks_base/pull/1#issuecomment-22830308 .

7alvi commented 11 years ago

Hmm..Doing this actually fixed the issue for me. In frameworks/base/core/res/res/drawable-hdpi, there are around 20 .pngs for stat_sys_download while in drawable-mdpi there are only 6 .pngs for same. Strangely, in CM's frameworks/base its the same. There are also 6 pngs in drawable-mdpi. And CM works fine without this 'patch' (?). it just fixed the issue for me. The logcat showed missing drawables. Maybe its not needed for every device, I guess.

scotthartbti commented 11 years ago

Strange... I checked the other reputable builds and they are all the same as mine and cm. What device are you on? Also, how long has this been an issue? Has it ever worked without those extra drawables? On Aug 19, 2013 11:09 AM, "Vishal Khanna" notifications@github.com wrote:

Hmm..Doing this actually fixed the issue for me. In frameworks/base/core/res/res/drawable-hdpi, there are around 20 .pngs for stat_sys_download while in drawable-mdpi there are only 6 .pngs for same. Strangely, in CM's frameworks/base its the same. There are also 6 pngs in drawable-mdpi. And CM works fine without this 'patch' (?). it just fixed the issue for me. The logcat showed missing drawables. Maybe its not needed for every device, I guess.

— Reply to this email directly or view it on GitHubhttps://github.com/scotthartbti/android_frameworks_base/pull/1#issuecomment-22878722 .

7alvi commented 11 years ago

I am on HTC Explorer/Pico. I checked sources of other builds I've compiled. They are the same as yours and CM (like you said). I actually reverted this commit and built again with original. It gave that FC again. Lol. It looks as if its needed for this ROM for my device only. You can ignore this pull. I see that it's not required for other builds for my device only. Strange.

scotthartbti commented 10 years ago

expired request.