search

scotthartbti / android_frameworks_base

Other
5 stars 28 forks source link

Settings->BeantStalk options->Status bar->Status Bar Options #15

Closed ghost closed 10 years ago

ghost commented 10 years ago

Hey Scott,

There seems to be a bug after the latest changes you made to this section. It is not possible to change the battery icon, change the clock and date settings. Apart from that the ROM is by far the best for me :)

scotthartbti commented 10 years ago

Thanks for the report. Pretty sure I know what the issue is and should be a quick fix On Feb 2, 2014 4:34 PM, "PatMac3" notifications@github.com wrote:

Hey Scott,

There seems to be a bug after the latest changes you made to this section. It is not possible to change the battery icon, change the clock and date settings. Apart from that the ROM is by far the best for me :)

Reply to this email directly or view it on GitHubhttps://github.com/scotthartbti/android_frameworks_base/issues/15 .

scotthartbti commented 10 years ago

fixed with settings commit https://github.com/scotthartbti/android_packages_apps_Settings/commit/2eccabc79db8af44ae2d029d35d5d04123bb438f

scotthartbti commented 10 years ago

Actually i reverted the status/navbar color option. The way it was implemented caused the original issues and then changing what needed to be changed caused the feature not to work at all. I wasnt originally happy with the overall feature implementation so i have just reverted the entire feature for now until i can take another look at it. Either way, issue resolved.