scotthartbti / android_frameworks_base

Other
5 stars 28 forks source link

long press navring not work #8

Closed ammarsj closed 10 years ago

ammarsj commented 10 years ago

hi scott. .the navring button long press not work we wait for fix… and if you can also make the navbar buttons 7 not only 5 as choice please.navbar not navring… thanks in advance for supper nice rom…

scotthartbti commented 10 years ago

This is working absolutely fine from my end.

ammarsj commented 10 years ago

strange… i see many users in nexus have the problem… any way thank you i will see from where the problem

scotthartbti commented 10 years ago

Ah now I see. Sorry I thought u meant regular navbar long press. I see now that its navring long press and can confirm it is an issue. I'll take a look and see what I can find.

ammarsj commented 10 years ago

yah this what i mean… thanks we wait.… and maybe also doing navbar 7 buttons as choice navbar not navring this time my friend

scotthartbti commented 10 years ago

Still looking into this one... Not seeing anything that i missed and nothing is sticking out to me.. Do you know if nav ring long press has ever worked in any of the previous versions? Would be helpful if i knew that information as im not sure if this has always been broken or if something that was recently commited caused it to stop working.

ammarsj commented 10 years ago

sorry but from first i9100 release from sooti it was broken. … not try this nice rom for our device support maybe you have some time to us please… i think sooti start build to us in 21/12 first release to i9100 users… one more thing please can you merge the package installer that show version info for apks during manuall instaler

ammarsj commented 10 years ago

ytymu9en

like this. … i found this in pound rom for i9100 user 4.4.2 if you look for its please

ammarsj commented 10 years ago

what about gesture anywhere feature do you think to merge it also.. please .it sooo nice feature…

ammarsj commented 10 years ago

sorry if i wrote more but i try all roms but never seen like your rom.…great rom. . thanks soo much

crunchbank commented 10 years ago

Does anybody use Navring any more? Might be worth excising it altogether?

scotthartbti commented 10 years ago

Navring long press fixed with this commit 832d4b43e6876e16db1baf8b025f3875eef9f226