Fixed text values not readjusting when yAxis range changes

scotthmurray / d3-book

Code examples for “Interactive Data Visualization for the Web”

http://d3book.com

Other

2.41k stars 1.79k forks source link

Fixed text values not readjusting when yAxis range changes #19

Closed 001ben closed 7 years ago

001ben commented 7 years ago

Fixed an issue where if a bar with a large value is removed, existing text values didn't readjust their Y position for the new Y axis range :)

scotthmurray commented 7 years ago

Thank you! I'll leave this open, but I'm not making any changes to the master (1st ed.) branch, as it wouldn't match the books that have already been printed. But I'm making refinements to the 2nd ed. branch, and will keep this in mind. Thanks!

scotthmurray commented 7 years ago

Closing this pull request, but the text of the 2nd edition better addresses this concern about the labels. Thanks!