search

scotthmurray / d3-book

Code examples for “Interactive Data Visualization for the Web”
http://d3book.com
Other
2.4k stars 1.79k forks source link

Chapter_07 - 09_time_scale.html #32

Closed Dekermanjian closed 6 years ago

Dekermanjian commented 6 years ago

The code does not work with the latest version of d3(5.5.0), you must use an older version.

scotthmurray commented 6 years ago

I'm sure that's true! These examples are made with work only with v4.x, and specifically v4.5.0, which is included here in this repo. They won't be kept up to date to work with all future versions of D3 (unless it's time to update for a 3rd edition of the book). :-)

Dekermanjian commented 6 years ago

Yes, of course I understand. I am currently going through the book, and thought it would be helpful to let you know what still works and what doesn't so that when you decide to update your book it will be simpler(I hope).

scotthmurray commented 6 years ago

Ah thanks! I will tag this with v5, so I can be sure to revisit for a future edition.

EricMaibach commented 5 years ago

FYI, I am using version 5 and to get it working I just had to change this line:

d3.csv("time_scale_data.csv", rowConverter, function(data) {

to:

d3.csv("time_scale_data.csv", rowConverter).then(function(data) {

It works in firefox fine, but does not work in Chrome. I have not had any luck getting v5 d3.csv working in Chrome. I am not sure if it is something I am doing wrong or a issue with d3.js and Chrome (seems most likely that I am doing something wrong).

BTW, thanks for the great book.

scotthmurray commented 5 years ago

Thanks, @EricMaibach!

mssalvadk commented 4 years ago

Thank you @EricMaibach, that line of code works in Chrome version 79.0++

mssalvadk commented 4 years ago

Thank you @Scottmurray! Great book!