search

scotthmurray / d3-book

Code examples for “Interactive Data Visualization for the Web”
http://d3book.com
Other
2.4k stars 1.79k forks source link

Fixed multiple tips being displayed during sort #43

Open sfavorite opened 4 years ago

sfavorite commented 4 years ago

Using selectAll should remove extra tool tips created when a sort is running. I attached a picture of my after a sort.

Screenshot from 2019-12-07 07-49-37

scotthmurray commented 4 years ago

Thanks @sfavorite! I have no immediate plans to update the master branch here, unless I were to update the book, to prevent confusion for readers. I'm going to leave this PR open and if and when I do an update, I will be sure to incorporate your contribution (and update the book text accordingly). Thanks!

sfavorite commented 4 years ago

I completely understand, Mr. Murray. Thank you for the consideration.

I have learned a lot from the book and am using D3 v5 and only a couple of changes have been needed to deal with promises - at least as far as chapter 11. Thanks again!