search

scotthovestadt / gigya

Gigya JavaScript REST SDK
MIT License
37 stars 62 forks source link

Added socialize.addConnection method #27

Closed pavelchernukhin closed 5 years ago

pavelchernukhin commented 5 years ago

Added socialize.addConnection method @see http://developers.gigya.com/display/GD/socialize.addConnection+REST

scotthovestadt commented 5 years ago

@pavelchernukhin First, thank you for the time it takes to put together a PR. I appreciate that you've taken pains to match existing code style, etc.

Unfortunately, I don't think I will be able to accept this as there isn't a use-case for it-- unless you have one, in which case please feel free to explain!

socialize.addConnection isn't a REST API call. It's an endpoint that you direct a user's browser to. On reaching that endpoint, they will then be redirected to a social network to login. This requires user-interaction.

This SDK is meant for server-to-server flows and does not require any user interaction.

pavelchernukhin commented 5 years ago

@scotthovestadt thanks for your response! Ok, if it only server to server sdk I'll close the PR