search

scottie1984 / swagger-ui-express

Adds middleware to your express app to serve the Swagger UI bound to your Swagger document. This acts as living documentation for your API hosted from within your app.
MIT License
1.42k stars 225 forks source link

Update to version 5 #228

Closed scottie1984 closed 2 years ago

zuozp8 commented 3 years ago

I copied index.js from this branch to my node_modules/swagger-ui-express/ and it fixed the issue and everything seems to work fine

Tornquist commented 3 years ago

@scottie1984 Is there a plan to release this?

I reviewed the conflicts and they're minor. I'm happy to fork this and put up another PR that's your preferred workflow.

scottie1984 commented 3 years ago

@scottie1984 Is there a plan to release this?

I reviewed the conflicts and they're minor. I'm happy to fork this and put up another PR that's your preferred workflow.

No- I reverted the issue with the shared variable in master instead of this fix.

To run multiple swagger ui instances I am going to document the serveFiles function

Tornquist commented 3 years ago

Great, thanks for the quick response.

rickihastings commented 2 years ago

@scottie1984 Is there a plan to release this? I reviewed the conflicts and they're minor. I'm happy to fork this and put up another PR that's your preferred workflow.

No- I reverted the issue with the shared variable in master instead of this fix.

To run multiple swagger ui instances I am going to document the serveFiles function

I don't think the changes to serveFiles fixes the issue you referenced in your comment here: https://github.com/scottie1984/swagger-ui-express/issues/183#issuecomment-727573737

If you think it does can you explain how this can be configured to fix #183?

scottie1984 commented 2 years ago

@rickihastings - yes this fix doesn't work. However for https://github.com/scottie1984/swagger-ui-express/issues/183 there seems to be a proxy fix that is not related to this module.