scottie1984 / swagger-ui-express

Adds middleware to your express app to serve the Swagger UI bound to your Swagger document. This acts as living documentation for your API hosted from within your app.
MIT License
1.41k stars 225 forks source link

customfavIcon does not work #287

Closed DinoscapeProgramming closed 2 years ago

DinoscapeProgramming commented 2 years ago

Describe the bug I‘ve declared a variable (uiOpts) and have customCss, customSiteTitle and customfavIcon in it, the first both things are working, but not customfavIcon. The file I specified is published on my site (https://url.dinoscape.tk/favicon.webp).

To Reproduce Steps to reproduce the behavior:

  1. Declare a variable
  2. Add „customfavIcon“ in it and add this variable after the configuration
  3. Restart your program
  4. Open the site and the favicon didn‘t changed

Expected behavior I can‘t change the favicon of my site.

Screenshots DB846D68-23EA-4805-B72F-1030F0FF3DD8 D5741FA2-645D-47E9-92A1-C8EEBFB93799

Tablet (yeah, i‘m using a tablet):

Additional context I tried to change the images in https://url.dinoscape.tk/docs/favicon-16x16.png and https://url.dinoscape.tk/docs/favicon-32x32.png, so the images changed, but it still doesn‘t work. Oh, and I’m using the version 3.0.

DinoscapeProgramming commented 2 years ago

I hope you can help me :)

scottie1984 commented 2 years ago

Seems to be showing the correct icon on my phone

DinoscapeProgramming commented 2 years ago

@scottie1984 Seems to be showing the correct icon on my phone

Can you make a screenshot, please?

scottie1984 commented 2 years ago

Screenshot 2022-02-22 at 22 01 04

DinoscapeProgramming commented 2 years ago

Screenshot 2022-02-22 at 22 01 04

So, this is the screenshot of https://url.dinoscape.tk/docs and not the main page?

DinoscapeProgramming commented 2 years ago

I really don‘t know what I should do, because in my other website the customfavIcon works.

DinoscapeProgramming commented 2 years ago

I really don‘t know what I should do, because in my other website the customfavIcon works.

That makes no sense

scottie1984 commented 2 years ago

https://url.dinoscape.tk/docs

Yes

Screenshot 2022-02-22 at 22 01 04

So, this is the screenshot of https://url.dinoscape.tk/docs and not the main page?

Yes - screenshot is from the Docs. Perhaps a browser caching issue - maybe do a hard reload, clear cache for your site, try another device or incognito browser

DinoscapeProgramming commented 2 years ago

https://url.dinoscape.tk/docs

Yes

Screenshot 2022-02-22 at 22 01 04

So, this is the screenshot of https://url.dinoscape.tk/docs and not the main page?

Yes - screenshot is from the Docs. Perhaps a browser caching issue - maybe do a hard reload, clear cache for your site, try another device or incognito browser

I found a solution in stackoverflow. So but I deleted the catch data of Safari, but it doesn‘t work…

DinoscapeProgramming commented 2 years ago

When I can‘t found a solution I will reopen this issue.